Return distinct data ids for GetTransactionRowIds.api - #7935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
A recent change was made to have the entire transaction respect the same useTransactionAuditCache setting. This change causes job derive actions to generate unexpected messages with double the data count. The double count was due to separate events in the transaction for sample creation and then adding the created sample to jobs.
workflow derive action success msg failures (develop)
This PR modifies GetTransactionRowIds to return distinct set of data ids.
This PR also modifies query.saveRows to respect useTransactionAuditCache setting passed in in extraContext.
Related Pull Requests
Changes